On Tue, Mar 11, 2025 at 9:13 AM Jianfeng Liu <liujianfeng1994@xxxxxxxxx> wrote:
>
> According to the schematic, pcie reset gpio is GPIO3_D4,
> not GPIO4_D4.
Thanks for the correction.
Also applies to the Orange Pi 5 Ultra.
I made the typo when starting with the Orange Pi 5 Plus with "gpio3
RK_PB3" and changed both "3" to "4".
I'm guessing u-boot has already initialized the device, otherwise the
problem would be more obvious.
>
> Fixes: c600d252dc52 ("arm64: dts: rockchip: Add Orange Pi 5 Max board")
> Signed-off-by: Jianfeng Liu <liujianfeng1994@xxxxxxxxx>
Reviewed-by: Jimmy Hon <honyuenkwun@xxxxxxxxx>
> ---
>
> arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-compact.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-compact.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-compact.dtsi
> index 6e4dcd8fff26..f748c6f760d8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-compact.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-compact.dtsi
> @@ -64,7 +64,7 @@ &led_blue_pwm {
>
> /* phy2 */
> &pcie2x1l1 {
> - reset-gpios = <&gpio4 RK_PD4 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_HIGH>;
> vpcie3v3-supply = <&vcc3v3_pcie_eth>;
> status = "okay";
> };
> --
> 2.43.0
>
