On 11/03/2025 15:55, Purva Yeshi wrote: >>> >>> Define properties: >>> Restrict `compatible` to `"nxp,lpc3220-pwm"` using `const`. >>> Limit `reg` to `maxItems: 1` to ensure a single register range. >>> Set `"#pwm-cells"` to `const: 3` for expected PWM cell properties. >>> >>> Mark `compatible` and `reg` as required properties. >> >> So it wasn't before? What are you implying here? > > The compatible and reg properties were already present in the .txt file, > but in a different format. I initially kept the commit message for them > but have now removed it. What does it mean "different format"? ... >>> >>> create mode 100644 Documentation/devicetree/bindings/pwm/lpc32xx-pwm.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.yaml b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.yaml >>> new file mode 100644 >>> index 000000000..3e41cd291 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.yaml >>> @@ -0,0 +1,45 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/pwm/nxp,lpc32xx-pwm.yaml# >> >> Filename matching compatible. > > In the lpc32xx-pwm.txt file, the compatible property was defined as > "nxp,lpc3220-pwm", so I have kept it the same. To ensure consistency > between the filename and compatible, should I rename the file to > nxp,lpc3220-pwm.yaml? Use whatever is there in the compatible property as the filename. Best regards, Krzysztof
