On Mon, Mar 10, 2025 at 4:21 PM Krzysztof Wilczynski <kw@xxxxxxxxx> wrote: > > Hello, > > [...] > > diff --git a/MAINTAINERS b/MAINTAINERS > > index d45c88955072..af2e4652bf3b 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -19752,6 +19752,7 @@ RASPBERRY PI RP1 PCI DRIVER > > M: Andrea della Porta <andrea.porta@xxxxxxxx> > > S: Maintained > > F: Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml > > +F: Documentation/devicetree/bindings/pci/pci-ep-bus.yaml > > F: Documentation/devicetree/bindings/pinctrl/raspberrypi,rp1-gpio.yaml > > F: include/dt-bindings/clock/rp1.h > > F: include/dt-bindings/misc/rp1.h > > I would be happy to pick this via the PCI tree as per the standard > operating procedure. However, the MAINTAINERS changes do not exist > for us yet, and are added in the first patch of the series, which is > not ideal. > > I can add the missing dependency manually, but that would cause issues > for linux-next tree, which is also not ideal. > > I saw some review feedback, as such, when you are going to be sending > another version, can you make MAINTAINERS changes to be the last patch, > perhaps. Basically, something standalone that perhaps whoever will pick > the misc patch could also pick and apply at the same time. > > Alternatively, someone else picking up the PCI dt-bindings would work, too. > > Your thoughts? I guess I missed this in review, but why is a common schema buried in a device maintainer entry? Also, an entry in MAINTAINERS is redundant anyway because get_maintainers.pl can fetch maintainers from the schema file. Rob
