RE: [PATCH net-next] dt-bindings: net: Define interrupt constraints for DWMAC vendor bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> -----Original Message-----
> From: Prabhakar <prabhakar.csengg@xxxxxxxxx>
> Sent: Sunday, March 9, 2025 9:33 AM
> To: Andrew Lunn <andrew+netdev@xxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Rob Herring
> <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Neil Armstrong <neil.armstrong@xxxxxxxxxx>; Kevin
> Hilman <khilman@xxxxxxxxxxxx>; Jerome Brunet <jbrunet@xxxxxxxxxxxx>;
> Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>; Shawn Guo
> <shawnguo@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>;
> Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>; Fabio Estevam
> <festevam@xxxxxxxxx>; Heiko Stuebner <heiko@xxxxxxxxx>; Maxime
> Coquelin <mcoquelin.stm32@xxxxxxxxx>; Alexandre Torgue
> <alexandre.torgue@xxxxxxxxxxx>; iwamatsu nobuhiro(岩松 信洋 ○DITC
> □DIT○OST) <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>; Matthias Brugger
> <matthias.bgg@xxxxxxxxx>; AngeloGioacchino Del Regno
> <angelogioacchino.delregno@xxxxxxxxxxxxx>; G. Jaya Kumaran
> <vineetha.g.jaya.kumaran@xxxxxxxxx>; Biao Huang
> <biao.huang@xxxxxxxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>; Linux
> Team <linux-imx@xxxxxxx>; David Wu <david.wu@xxxxxxxxxxxxxx>;
> Christophe Roullier <christophe.roullier@xxxxxxxxxxx>; Russell King (Oracle)
> <rmk+kernel@xxxxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-amlogic@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx;
> linux-rockchip@xxxxxxxxxxxxxxxxxxx;
> linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx;
> linux-mediatek@xxxxxxxxxxxxxxxxxxx; Prabhakar
> <prabhakar.csengg@xxxxxxxxx>; Lad Prabhakar
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Subject: [PATCH net-next] dt-bindings: net: Define interrupt constraints for
> DWMAC vendor bindings
> 
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> 
> The `snps,dwmac.yaml` binding currently sets `maxItems: 3` for the
> `interrupts` and `interrupt-names` properties, but vendor bindings selecting
> `snps,dwmac.yaml` do not impose these limits.
> 
> Define constraints for `interrupts` and `interrupt-names` properties in
> various DWMAC vendor bindings to ensure proper validation and consistency.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> Hi All,
> 
> Based on recent patch [0] which increases the interrupts to 11 and adds
> `additionalItems: true` its good to have constraints to validate the schema. Ive
> made the changes based on the DT binding doc and the users. Ive ran dt
> binding checks to ensure the constraints are valid. Please let me know if you'd
> like me to split this patch or if any of the constraints are incorrect, as I don't
> have documentation for all of these platforms.
> 
> https://lore.kernel.org/all/20250308200921.1089980-2-prabhakar.mahadev-la
> d.rj@xxxxxxxxxxxxxx/
> 
> Cheers, Prabhakar
> ---

>  .../bindings/net/toshiba,visconti-dwmac.yaml           |  6 ++++++

Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>

Best regards,
  Nobuhiro






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux