On Fri, Mar 07 2025 at 16:49, Xianwei Zhao via wrote:
>
> if (type == IRQ_TYPE_EDGE_BOTH) {
> val |= BIT(ctl->params->edge_both_offset + idx);
Not new, but this really should be 'val = ...'
> - meson_gpio_irq_update_bits(ctl, REG_EDGE_POL_S4,
> + meson_gpio_irq_update_bits(ctl, params->edge_pol_reg,
> BIT(ctl->params->edge_both_offset + idx), val);
and this BIT() calculation is obviously redundant as it is the same as @val.
Would be nice to have that cleaned up.
With that fixed:
Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
