Re: [PATCH net-next 0/7] net: stmmac: deprecate "snps,en-tx-lpi-clockgating" property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 10, 2025 at 04:35:55PM +0000, Conor Dooley wrote:
> On Sun, Mar 09, 2025 at 03:01:45PM +0000, Russell King (Oracle) wrote:
> > Hi,
> > 
> > This series deprecates the "snps,en-tx-lpi-clockgating" property for
> > stmmac.
> > 
> > MII Transmit clock gating, where the MAC hardware supports gating this
> > clock, is a function of the connected PHY capabilities, which it
> > reports through its status register.
> > 
> > GMAC versions that support transmit clock gating twiddle the LPITCSE
> > bit accordingly in the LPI control/status register, which is handled
> > by the GMAC core specific code.
> > 
> > So, "snps,en-tx-lpi-clockgating" not something that is a GMAC property,
> > but is a work-around for phylib not providing an interface to determine
> > whether the PHY allows the transmit clock to be disabled.
> > 
> > This series converts the two SoCs that make use of this property (which,
> > I hasten to add, is set in the SoC code) to use the PHY capability bit
> > instead of a DT property, then removes the DT property from the .dtsi,
> > deprecates it in the snps,dwmac binding, and finally in the stmmac code.
> > 
> 
> > I am expecting some discussion on how to merge this, as I think the
> > order in which these changes is made is important - we don't want to
> > deprecate the old way until the new code has landed.
> 
> I'm happy enough to have the jh7110 dtsi change go via netdev, rather
> than sit on till the driver change propagates to my tree in a release's
> time.

Thanks! Could I have a r-b or a-b for it please?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux