On 3/10/25 2:32 PM, Rob Herring wrote:
On Sat, Mar 08, 2025 at 08:33:38PM +0200, Cosmin Tanislav wrote:
Devices to be added in following patches don't use I2C gate.
Make this property conditional on the compatible strings.
Signed-off-by: Cosmin Tanislav <demonsingur@xxxxxxxxx>
---
.../bindings/media/i2c/maxim,max96714.yaml | 21 ++++++++++++-------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml
index 2f453189338f..d0a2aaf7df9c 100644
--- a/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96714.yaml
@@ -84,14 +84,6 @@ properties:
required:
- port@1
- i2c-gate:
- $ref: /schemas/i2c/i2c-gate.yaml
- unevaluatedProperties: false
- description:
- The MAX96714 will pass through and forward the I2C requests from the
- incoming I2C bus over the GMSL2 link. Therefore it supports an i2c-gate
- subnode to configure a serializer.
-
port0-poc-supply:
description: Regulator providing Power over Coax for the GMSL port
@@ -101,6 +93,19 @@ required:
- ports
additionalProperties: false
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - maxim,max96714
+ - maxim,max96714f
+ then:
+ properties:
+ i2c-gate:
Leave the original definition, invert the 'if', and here you just need:
i2c-gate: false
Hi Rob.
Thanks for your comments.
After noticing that my dt-schema validation scripts are failing (because
of the jsonschema version incompatibility), I fixed them and then fixed
all the issues and sent a V2 where I introduce a separate file for these
bindings since they all have a different number of ports compared to the
max96714 one.
So the V1 of these patches have been superseded.
+ $ref: /schemas/i2c/i2c-gate.yaml
+ unevaluatedProperties: false
examples:
- |
--
2.48.1
