Re: [PATCH v1 1/4] coresight: tmc: Introduce new APIs to get the RWP offset of ETR buffer

[Jie Gan <quic_jiegan@xxxxxxxxxxx>]

On 3/10/2025 5:07 PM, Krzysztof Kozlowski wrote:
> On 10/03/2025 10:04, Jie Gan wrote:
> > +static long tmc_sg_get_rwp_offset(struct tmc_drvdata *drvdata)
> > +{
> > +	struct etr_buf *etr_buf = drvdata->sysfs_buf;
> > +	struct etr_sg_table *etr_table = etr_buf->private;
> > +	struct tmc_sg_table *table = etr_table->sg_table;
> > +	long w_offset;
> > +	u64 rwp;
> > +
> > +	rwp = tmc_read_rwp(drvdata);
> > +	w_offset = tmc_sg_get_data_page_offset(table, rwp);
> > +
> > +	return w_offset;
> > +}
> > +
> > +/*
> > + * Retrieve the offset to the write pointer of the ETR buffer based on whether
> > + * the memory mode is SG, flat or reserved.
> > + */
> > +long tmc_get_rwp_offset(struct tmc_drvdata *drvdata)
>
> You need kerneldoc for exports.

Hi Krzysztof,

Sorry for the insufficient description for an export function. Will fix 
it in next version.

Thanks,
Jie

> Best regards,
> Krzysztof