On 10/03/2025 08:20, Matthias Fend wrote: > Hi Conor, > > Am 28.02.2025 um 19:24 schrieb Conor Dooley: >> On Fri, Feb 28, 2025 at 11:31:23AM +0100, Matthias Fend wrote: >>> Document Texas Instruments TPS61310/TPS61311 flash LED driver devicetree >>> bindings. >>> >>> Signed-off-by: Matthias Fend <matthias.fend@xxxxxxxxx> >>> --- >>> .../devicetree/bindings/leds/ti,tps6131x.yaml | 123 +++++++++++++++++++++ >>> 1 file changed, 123 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/leds/ti,tps6131x.yaml b/Documentation/devicetree/bindings/leds/ti,tps6131x.yaml >>> new file mode 100644 >>> index 0000000000000000000000000000000000000000..c08b3cef7abcec07237d3271456ff1f888b2b809 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/leds/ti,tps6131x.yaml >> >> With a filename matching one of the compatibles in the file, >> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > thank you very much for your feedback. > Since I found different variants in the LED bindings, I wasn't quite > sure here. > So is it okay if I simply rename the file to 'ti,tps61310.yaml', even > though there are multiple compatible strings and the driver is called > leds-tps6131x? > I think that was exactly the review comment you got. Best regards, Krzysztof