> +static inline u32 read_reg(struct apple_spmi *spmi, int offset) > +{ > + return readl(spmi->regs + offset); > +} > + > +static inline void write_reg(u32 value, struct apple_spmi *spmi, int offset) > +{ > + writel(value, spmi->regs + offset); > +} At this point I don't think these are gaining us anything. Can we inline them?