Hi Conor,
On 2025-03-07 16:42, Conor Dooley wrote:
> On Thu, Mar 06, 2025 at 10:13:54PM +0000, Jonas Karlman wrote:
>> Rockchip RK3528 has two Ethernet controllers based on Synopsys DWC
>> Ethernet QoS IP.
>>
>> Add compatible string for the RK3528 variant.
>>
>> Signed-off-by: Jonas Karlman <jonas@xxxxxxxxx>
>> ---
>> I was not able to restrict the minItems change to only apply to the new
>> compatible, please advise on how to properly restrict the minItems
>> change if needed.
>
> What do you mean by that? As in, what did you try and did not work?
> Usually you do something like
> if:
> not:
> compatible:
> contains:
> rockchip,rk3528-gmac
> then:
> properties:
> clocks:
> minItems: 5
>
Thanks, this seem to work, will use in a v2.
I tried to do something opposite and instead set minItems: 4 when
compatible contains rockchip,rk3528-gmac:
if:
compatible:
contains:
rockchip,rk3528-gmac
then:
properties:
clocks:
minItems: 4
but that resulted in something like:
rockchip/rk3528-radxa-e20c.dtb: ethernet@ffbe0000: clocks: [[7, 173], [7, 172], [7, 171], [7, 170]] is too short
Regards,
Jonas
>>
>> Also, because snps,dwmac-4.20a is already listed in snps,dwmac.yaml
>> adding the rockchip,rk3528-gmac compatible did not seem necessary.
>> ---
>> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
>> index 05a5605f1b51..3c25b49bd78e 100644
>> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
>> @@ -24,6 +24,7 @@ select:
>> - rockchip,rk3366-gmac
>> - rockchip,rk3368-gmac
>> - rockchip,rk3399-gmac
>> + - rockchip,rk3528-gmac
>> - rockchip,rk3568-gmac
>> - rockchip,rk3576-gmac
>> - rockchip,rk3588-gmac
>> @@ -49,6 +50,7 @@ properties:
>> - rockchip,rv1108-gmac
>> - items:
>> - enum:
>> + - rockchip,rk3528-gmac
>> - rockchip,rk3568-gmac
>> - rockchip,rk3576-gmac
>> - rockchip,rk3588-gmac
>> @@ -56,7 +58,7 @@ properties:
>> - const: snps,dwmac-4.20a
>>
>> clocks:
>> - minItems: 5
>> + minItems: 4
>> maxItems: 8
>>
>> clock-names:
>> --
>> 2.48.1
>>
