On 07/03/2025 13:47, Darren.Ye wrote: > +int mt8196_enable_cm_bypass(struct mtk_base_afe *afe, int id, bool en) > +{ > + int reg = AFE_CM0_CON0 + 0x10 * id; > + > + mtk_regmap_update_bits(afe->regmap, reg, AFE_CM_BYPASS_MODE_MASK, > + en, AFE_CM_BYPASS_MODE_SFT); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(mt8196_enable_cm_bypass); > + > +MODULE_DESCRIPTION("Mediatek afe cm"); > +MODULE_AUTHOR("darren ye <darren.ye@xxxxxxxxxxxx>"); > +MODULE_LICENSE("GPL"); If this is module, where is Makefile and Kconfig? All previous comments about missing kerneldoc also apply. Best regards, Krzysztof