On Thu, Mar 06, 2025 at 09:09:46PM +0000, Jonas Karlman wrote:
> @@ -1813,8 +1564,24 @@ static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev,
>
> bsp_priv->grf = syscon_regmap_lookup_by_phandle(dev->of_node,
> "rockchip,grf");
> - bsp_priv->php_grf = syscon_regmap_lookup_by_phandle(dev->of_node,
> - "rockchip,php-grf");
> + if (IS_ERR(bsp_priv->grf)) {
> + ret = PTR_ERR(bsp_priv->grf);
> + dev_err_probe(dev, ret, "failed to lookup rockchip,grf\n");
> + return ERR_PTR(ret);
Did you consider using ERR_CAST() for these, which would look like this:
dev_err_probe(dev, PTR_ERR(bsp_priv->grf),
"failed to lookup rockchip,grf\n");
return ERR_CAST(bsp_priv->grf);
?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
