Hi,
> + sdio0: mmc@ffc10000 {
> + compatible = "rockchip,rk3528-dw-mshc",
> + "rockchip,rk3288-dw-mshc";
> + reg = <0x0 0xffc10000 0x0 0x4000>;
> + clocks = <&cru HCLK_SDIO0>,
> + <&cru CCLK_SRC_SDIO0>,
> + <&cru SCLK_SDIO0_DRV>,
> + <&cru SCLK_SDIO0_SAMPLE>;
> + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample";
> + fifo-depth = <0x100>;
> + interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
> + max-frequency = <150000000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdio0_bus4>, <&sdio0_clk>, <&sdio0_cmd>,
> + <&sdio0_det>, <&sdio0_pwren>;
The sdio module is usually "non-removable", no need det,
and pwren may be other gpio (use mmc-pwrseq). So it should
be `pinctrl-0 = <&sdio0_bus4>, <&sdio0_clk>, <&sdio0_cmd>;`
> + resets = <&cru SRST_H_SDIO0>;
> + reset-names = "reset";
> + status = "disabled";
> + };
> +
> + sdio1: mmc@ffc20000 {
> + compatible = "rockchip,rk3528-dw-mshc",
> + "rockchip,rk3288-dw-mshc";
> + reg = <0x0 0xffc20000 0x0 0x4000>;
> + clocks = <&cru HCLK_SDIO1>,
> + <&cru CCLK_SRC_SDIO1>,
> + <&cru SCLK_SDIO1_DRV>,
> + <&cru SCLK_SDIO1_SAMPLE>;
> + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample";
> + fifo-depth = <0x100>;
> + interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
> + max-frequency = <150000000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdio1_bus4>, <&sdio1_clk>, <&sdio1_cmd>,
> + <&sdio1_det>, <&sdio1_pwren>;
Same here.
> + resets = <&cru SRST_H_SDIO1>;
> + reset-names = "reset";
> + status = "disabled";
> + };
Thanks,
Chukun
--
2.25.1
