RE: [PATCH 1/8] dt-bindings: memory: Document RZ/G3E support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 06 March 2025 12:58
> Subject: Re: [PATCH 1/8] dt-bindings: memory: Document RZ/G3E support
> 
> Hi Biju,
> 
> On Thu, 6 Mar 2025 at 12:25, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> On Thu, 6 Mar 2025
> > > at 11:59, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > > > > -----Original Message-----
> > > > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > > > Sent: 06 March 2025 10:44
> > > > > Subject: Re: [PATCH 1/8] dt-bindings: memory: Document RZ/G3E
> > > > > support
> > > > >
> > > > > On Fri, 28 Feb 2025 at 17:08, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > > > > > Document support for the Expanded Serial Peripheral Interface
> > > > > > (xSPI) Controller in the Renesas RZ/G3E (R9A09G047) SoC.
> > > > > >
> > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > > >
> > > > > Thanks for your patch!
> > > > >
> > > > > > --- /dev/null
> > > > > > +++ b/Documentation/devicetree/bindings/memory-controllers/ren
> > > > > > +++ esas
> > > > > > +++ ,rz-
> > > > > > +++ xspi.yaml
> > > > >
> > > > > > +properties:
> > > > > > +  compatible:
> > > > > > +    items:
> > > > > > +      - const: renesas,r9a09g047-xspi  # RZ/G3E
> > > > > > +      - const: renesas,rz-xspi         # a generic RZ xSPI device
> > > > >
> > > > > Is this the same variant of RPC-IF as used on older "RZ" SoCs
> > > > > like
> > > > > RZ/A1 and RZ/A2?
> > > > > If the answer is yes, then I do not object against introducing rz-xspi.
> > > >
> > > > No, by looking at the registers,
> > > > I think one on RZ/A1 and RZ/A2 is same as RZ/G2L. So
> > > > renesas,rzg2l-rpc-if will fit there.
> > >
> > > In that case I think "renesas,rz-xspi" is a too generic name.
> >
> > if rz-xspi is too generic, what about using rzg3e-xspi?
> >
> > Note:
> > RZ/G3S and RZ/V2H have similar IP's
> 
> Just drop the generic fallback?
> RZ/G3S and RZ/V2H can use "renesas,r9a09g047-xspi" as a fallback.

Agreed.

Cheers,
Biju




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux