> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 06 March 2025 12:45
> To: Swathi K S <swathi.ks@xxxxxxxxxxx>; krzk+dt@xxxxxxxxxx;
> andrew+netdev@xxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; robh@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; richardcochran@xxxxxxxxx;
> mcoquelin.stm32@xxxxxxxxx; alexandre.torgue@xxxxxxxxxxx
> Cc: rmk+kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> pankaj.dubey@xxxxxxxxxxx; ravi.patel@xxxxxxxxxxx;
> gost.dev@xxxxxxxxxxx
> Subject: Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree
> bindings
>
> On 05/03/2025 10:12, Swathi K S wrote:
> > Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
> > Ethernet YAML schema to enable the DT validation.
> >
> > Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>
> > Signed-off-by: Ravi Patel <ravi.patel@xxxxxxxxxxx>
> > Signed-off-by: Swathi K S <swathi.ks@xxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/net/snps,dwmac.yaml | 5 +-
> > .../bindings/net/tesla,fsd-ethqos.yaml | 118 ++++++++++++++++++
> > 2 files changed, 121 insertions(+), 2 deletions(-) create mode
> > 100644 Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml
> >
>
> I tried and did not see any differences, so point me exactly to any difference
> in the binding (binding!) which would justify dropping review?
Added the following in the example given in DT binding doc:
assigned-clocks = <&clock_peric PERIC_EQOS_PHYRXCLK_MUX>,
<&clock_peric PERIC_EQOS_PHYRXCLK>;
assigned-clock-parents = <&clock_peric PERIC_EQOS_PHYRXCLK>;
Given the significance of these changes, I assumed the changes need to be reviewed again.
That was why the tag was removed. Please correct me if I am wrong and provide your feedback on this patch.
- Swathi
>
> Best regards,
> Krzysztof
