> > @@ -0,0 +1,961 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * es8389.c -- ES8389/ES8390 ALSA SoC Audio Codec
> > + *
> > + * Copyright (C) 2025 Everest Semiconductor Co., Ltd
>
> Please make the entire comment block a C++ one so things look more
> consistent.
I will fix it
> > + if (es8389->dmic == true) {
> > + regmap_update_bits(es8389->regmap, ES8389_DMIC_EN, 0xC0, 0xC0);
> > + regmap_update_bits(es8389->regmap, ES8389_ADC_MODE, 0x03, 0x03);
> > + } else {
> > + regmap_update_bits(es8389->regmap, ES8389_DMIC_EN, 0xC0, 0x00);
> > + regmap_update_bits(es8389->regmap, ES8389_ADC_MODE, 0x03, 0x00);
> > + }
>
> We also had the DMIC mux, is that useful as a runtime control when we
> have firmware data telling us if there's a DMIC? Can both a DMIC and
> analog input be present in the same system?
>
> It does still look like a lot of these settings might be things that
> should be user controllable...
I'm going to remove es8389->dmic and everest,dmic-enabled and use only DMIC_MUX
