On Wed, May 06, 2015 at 12:34:30PM +0200, Jens Kuske wrote: > >> + SUNXI_PIN(SUNXI_PINCTRL_PIN(A, 6), > >> + SUNXI_FUNCTION(0x0, "gpio_in"), > >> + SUNXI_FUNCTION(0x1, "gpio_out"), > >> + SUNXI_FUNCTION(0x2, "scr"), /* PWREN */ > > > > The datasheet uses "SIM" for this, why have you changed the name here? > > Thought I had changed that back. I first used scr because the > responsible module is called scr everywhere else (clocks, memory map). > Looks like I messed it up now and called the clocks "sim" instead... > > I think I should also redo the dtsi and use scr for the clock again, to > stay compatible with how it was called in Manual and earlier sunxi SoCs. It seems reasonable :) Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
