On Tue, Mar 04, 2025 at 11:36:32AM -0600, Bjorn Helgaas wrote:
> On Tue, Mar 04, 2025 at 03:12:38PM +0800, Inochi Amaoto wrote:
> > Add support for DesignWare-based PCIe controller in SG2044 SoC.
>
> > +static void sophgo_intx_irq_eoi(struct irq_data *d)
> > +{
> > +}
>
> The empty .irq_eoi() is unusual. Why do you need it?
>
> I see that the existence of chip->irq_eoi() makes a difference in
> chained_irq_enter() and chained_irq_exit(), but I'm surprised that
> this is the only driver in drivers/pci/controller/ that implements an
> empty .irq_eoi().
>
> A comment here about what is special would be helpful.
>
It is more like a mistake that from the vendor code
that I refer to it. This should be a level irq, and
I haven't tested it as I does not have a device use
INTx. I try to get a test device will replace this
empty eoi with handle_level_irq if I can confirm it.
Thanks for pointing to this.
Regards,
Inochi
