Hi,
> + aliases {
> + mmc0 = &sdmmc;
s/mmc0/mmc1
> +&sdmmc {
> + bus-width = <4>;
> + cap-mmc-highspeed;
> + cap-sd-highspeed;
I think for sdcard, only cap-sd-highspeed
is needed, not cap-mmc-highspeed?
> + disable-wp;
Missing pinctrl.
> + rockchip,default-sample-phase = <90>;
It seems that all rk3528 devices need to set this
default phase, so maybe this can be placed in dtsi?
> + sd-uhs-sdr104;
The rk3528 devices uses gpio to switch IO voltage, maybe
more modes should be added here like vendor kernel?
And these devices use 3.3V IO voltage by default.
sd-uhs-sdr12;
sd-uhs-sdr25;
sd-uhs-sdr50;
sd-uhs-sdr104;
Thanks,
Chukun
--
2.25.1
