On Tue, Mar 04, 2025 at 10:30:15AM +0800, Stone Zhang wrote:
>
>
> On 2/27/2025 11:15 PM, Dmitry Baryshkov wrote:
> > On Thu, Feb 27, 2025 at 02:54:39PM +0800, Stone Zhang wrote:
> > > Enable WLAN on qcs8300-ride by adding a node for the PMU module
> > > of the WCN6855 and assigning its LDO power outputs to the existing
> > > WiFi module.
> > >
> > > Signed-off-by: Stone Zhang <quic_stonez@xxxxxxxxxxx>
> > > ---
> > > arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 100 ++++++++++++++++++++++
> > > 1 file changed, 100 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> > > index 3e246fbc5759..e9304420c93e 100644
> > > --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> > > +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> > > @@ -22,6 +22,80 @@ aliases {
> > > chosen {
> > > stdout-path = "serial0:115200n8";
> > > };
> > > +
> > > + vreg_conn_1p8: vreg-conn-1p8 {
> > > + compatible = "regulator-fixed";
> > > + regulator-name = "vreg_conn_1p8";
> > > + regulator-min-microvolt = <1800000>;
> > > + regulator-max-microvolt = <1800000>;
> > > + startup-delay-us = <4000>;
> > > + enable-active-high;
> > > + gpio = <&pmm8650au_1_gpios 4 GPIO_ACTIVE_HIGH>;
> > > + };
> > > +
> > > + vreg_conn_pa: vreg-conn-pa {
> > > + compatible = "regulator-fixed";
> > > + regulator-name = "vreg_conn_pa";
> > > + regulator-min-microvolt = <1800000>;
> > > + regulator-max-microvolt = <1800000>;
> > > + startup-delay-us = <4000>;
> > > + enable-active-high;
> > > + gpio = <&pmm8650au_1_gpios 6 GPIO_ACTIVE_HIGH>;
> > > + };
> > > +
> > > + wcn6855-pmu {
> > > + compatible = "qcom,wcn6855-pmu";
> > > +
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&wlan_en_state>;
> > > +
> > > + vddaon-supply = <&vreg_conn_pa>;
> > > + vddpmu-supply = <&vreg_conn_1p8>;
> >
> > This is very incomplete. Compare it to sa8775p-ride.dtsi.
> It will be completed according to the supply voltage defined in the power
> sequence driver.
The Devicetree binding, not the Linux device driver, is what defines
what should go into the Devicetree source. That way the binding forms a
contract between the dtb file and any operating system reading that dtb
file.
If you ran the required "make qcom/qcs8300-ride.dtb CHECK_DTBS=1 W=1"
(short for "make dtbs_check W=1") you would have noticed that your patch
introduces the following errors:
+arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: wifi@0: 'vddrfa1p8-supply' is a required property
+arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: pinctrl@f100000: wlan-en-state: 'oneOf' conditional failed, one must be fixed:
+arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: wcn6855-pmu: 'vddio-supply' is a required property
+arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: wcn6855-pmu: 'vddpmumx-supply' is a required property
+arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: wcn6855-pmu: 'vddpmucx-supply' is a required property
+arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: wcn6855-pmu: 'vddrfa0p95-supply' is a required property
+arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: wcn6855-pmu: 'vddrfa1p3-supply' is a required property
+arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: wcn6855-pmu: 'vddrfa1p9-supply' is a required property
+arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: wcn6855-pmu: 'vddpcie1p3-supply' is a required property
+arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: wcn6855-pmu: 'vddpcie1p9-supply' is a required property
There should be 0 new errors for me to merge the patch.
Regards,
Bjorn
