On 05/06/2015 09:31 AM, Arnd Bergmann wrote: > On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote: >>>> @@ -533,6 +567,16 @@ >>>> interrupts = <0x0 0x4f 0x4>; >>>> }; >>>> >>>> + sdhc0: sdhc@1c000000 { >>>> + device_type = "sdhc"; >>> >>> device_type generally should not be used (there are a few exceptions). >> >> Okay !! >> > > While we're at it, please change sdhc@1c000000 to mmc@1c000000. > Even though Linux does not care, we try to use the standard device > names for consistency. Do we have a list of these names somewhere? Normally I do use ePARP - generic names recommendation but mmc or sdhci are not listed there. Both combination mmc@ or sdhci@ are used in the kernel. On zynq and zynqmp we do use shdci@. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html