On Wed, Feb 26, 2025 at 11:29:54AM -0600, Rob Herring (Arm) wrote: > > On Wed, 26 Feb 2025 16:57:17 +0100, J. Neuschäfer wrote: > > The devicetree bindings for Freescale DMA engines have so far existed as > > a text file. This patch converts them to YAML, and specifies all the > > compatible strings currently in use in arch/powerpc/boot/dts. > > > > Signed-off-by: J. Neuschäfer <j.ne@xxxxxxxxxx> > > --- > > I considered referencing dma-controller.yaml, but that requires > > the #dma-cells property (via dma-common.yaml), and I'm now sure which > > value it should have, if any. Therefore I did not reference > > dma-controller.yaml. > > > > V3: > > - split out as a single patch > > - restructure "description" definitions to use "items:" as much as possible > > - remove useless description of interrupts in fsl,elo3-dma > > - rename DMA controller nodes to dma-controller@... > > - use IRQ_TYPE_* constants in examples > > - define unit address format for DMA channel nodes > > - drop interrupts-parent properties from examples > > > > V2: > > - part of series [PATCH v2 00/12] YAML conversion of several Freescale/PowerPC DT bindings > > Link: https://lore.kernel.org/lkml/20250207-ppcyaml-v2-5-8137b0c42526@xxxxxxxxxx/ > > - remove unnecessary multiline markers > > - fix additionalProperties to always be false > > - add description/maxItems to interrupts > > - add missing #address-cells/#size-cells properties > > - convert "Note on DMA channel compatible properties" to YAML by listing > > fsl,ssi-dma-channel as a valid compatible value > > - fix property ordering in examples: compatible and reg come first > > - add missing newlines in examples > > - trim subject line (remove "bindings") > > --- > > .../devicetree/bindings/dma/fsl,elo-dma.yaml | 137 ++++++++++++++ > > .../devicetree/bindings/dma/fsl,elo3-dma.yaml | 125 +++++++++++++ > > .../devicetree/bindings/dma/fsl,eloplus-dma.yaml | 132 +++++++++++++ > > .../devicetree/bindings/powerpc/fsl/dma.txt | 204 --------------------- > > 4 files changed, 394 insertions(+), 204 deletions(-) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/fsl,elo-dma.example.dtb: dma-controller@82a8: '#dma-cells' is a required property > from schema $id: http://devicetree.org/schemas/dma/dma-controller.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/fsl,eloplus-dma.example.dtb: dma-controller@21300: '#dma-cells' is a required property > from schema $id: http://devicetree.org/schemas/dma/dma-controller.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/fsl,elo3-dma.example.dtb: dma-controller@100300: '#dma-cells' is a required property > from schema $id: http://devicetree.org/schemas/dma/dma-controller.yaml# Just stick with 'dma' for node name as that's what .dts files are using and 'dma-controller' is reserved for users of DMA provider binding. Rob
