Hello, [...] > + err = devm_request_irq(dev, irq, amd_mdb_pcie_intr_handler, > + IRQF_NO_THREAD, intr_cause[i].sym, pcie); > + if (err) { > + dev_err(dev, "Failed to request IRQ %d\n", irq); > + return err; > + } > + } Out of curiosity: would exposing error values be of any benefit to the users of the driver? So, perhaps: if (err) { dev_err(dev, "Failed to request IRQ %d, err=%d\n", irq, err); return err; } Thoughts? Krzysztof