On Sun, Mar 02, 2025 at 08:51:54PM +0100, Alexander Sverdlin wrote: > From: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx> > > Add RTC devicetree binding for Sophgo CV1800 series SoC. The device is > called RTC, but contains control registers of other HW blocks in its > address space, most notably of Power-on-Reset (PoR) module, DW8051 IP > (MCU core), accompanying SRAM, hence putting it in MFD subsystem. Assuming this is integrated block in the CV1800 SoC, then this should go to soc/ and probably called system controller or similarly. How is it called in the datasheet? > > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx> > --- > Changelog: > v12: > - maintainer Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx> -> sophgo@xxxxxxxxxxxxxxx > - dropped Reviewed-by: Krzysztof Kozlowski > - link to TRM > - mentioned 8051 core in the description > - binding is now MFD, not RTC > - added "syscon" compatible > - added "interrupt-names", "clock-names" (because of added PM/remoteproc) > - main compatible "sophgo,cv1800-rtc" -> "sophgo,cv1800b-rtc" > > .../bindings/mfd/sophgo,cv1800b-rtc.yaml | 86 +++++++++++++++++++ > 1 file changed, 86 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/sophgo,cv1800b-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/mfd/sophgo,cv1800b-rtc.yaml > new file mode 100644 > index 000000000000..b80d68502c48 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/sophgo,cv1800b-rtc.yaml > @@ -0,0 +1,86 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/sophgo,cv1800b-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Real Time Clock of the Sophgo CV1800 SoC > + > +description: > + The RTC (Real Time Clock) is an independently powered module in the chip. It > + contains a 32KHz oscillator and a Power-On-Reset (POR) sub-module, which can > + be used for time display and scheduled alarm produce. In addition, the > + hardware state machine provides triggering and timing control for chip > + power-on, power-off and reset. > + > + Furthermore, the 8051 subsystem is located within RTCSYS and is independently > + powered. System software can use the 8051 to manage wake conditions and wake > + the system while the system is asleep, and communicate with external devices > + through peripheral controllers. > + > + Technical Reference Manual available at > + https://github.com/sophgo/sophgo-doc/tree/main/SG200X/TRM > + > +maintainers: > + - sophgo@xxxxxxxxxxxxxxx > + > +allOf: > + - $ref: /schemas/rtc/rtc.yaml# > + > +properties: > + compatible: > + items: > + - const: sophgo,cv1800b-rtc > + - const: syscon Binding is fine, but still open topics are: placement and compatible name. Best regards, Krzysztof
