On Thu, 27 Feb 2025 at 09:15, Johan Hovold <johan+linaro@xxxxxxxxxx> wrote:
>
> The l12b and l15b supplies are used by components that are not (fully)
> described (and some never will be) and must never be disabled.
Out of curiosity, what are these components?
>
> Mark the regulators as always-on to prevent them from being disabled,
> for example, when consumers probe defer or suspend.
>
> Note that these supplies currently have no consumers described in
> mainline.
>
> Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345")
> Cc: stable@xxxxxxxxxxxxxxx # 6.13
> Cc: Aleksandrs Vinarskis <alex.vinarskis@xxxxxxxxx>
> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
Reviewed-by: Aleksandrs Vinarskis <alex.vinarskis@xxxxxxxxx>
Tested-by: Aleksandrs Vinarskis <alex.vinarskis@xxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> index 86e87f03b0ec..90f588ed7d63 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> @@ -359,6 +359,7 @@ vreg_l12b_1p2: ldo12 {
> regulator-min-microvolt = <1200000>;
> regulator-max-microvolt = <1200000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + regulator-always-on;
> };
>
> vreg_l13b_3p0: ldo13 {
> @@ -380,6 +381,7 @@ vreg_l15b_1p8: ldo15 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + regulator-always-on;
> };
>
> vreg_l17b_2p5: ldo17 {
> --
> 2.45.3
>
