Hi Doug, On 2025/2/25 9:40, Doug Anderson wrote:
Hi, On Mon, Feb 24, 2025 at 12:14 AM Damon Ding <damon.ding@xxxxxxxxxxxxxx> wrote:With the commit f37952339cc2 ("drm/bridge: analogix_dp: handle clock via runtime PM"), the PM operations can help enable/disable the clock. The err_disable_clk label and clk_disable_unprepare() operations are no longer necessary because the analogix_dp_resume() will not be called during probing. Fixes: f37952339cc2 ("drm/bridge: analogix_dp: handle clock via runtime PM")When possible "Fixes" should be pushed to the start of your series so it's obvious they have no dependencies when being picked to stable kernels. That should be possible here.Signed-off-by: Damon Ding <damon.ding@xxxxxxxxxxxxxx> --- .../gpu/drm/bridge/analogix/analogix_dp_core.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index e23af674d91c..d9dafb038e7a 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1608,10 +1608,8 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); dp->reg_base = devm_ioremap_resource(&pdev->dev, res);There is a context conflict when I apply to drm-misc-next because of commit 43c00fb1a518 ("drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()"). You probably should rebase and re-apply. Aside from the context conflict, this looks great to me: Suggested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
After rebasing, I found the conflict. I will move this patch to a separate series and ensure it has no dependencies.
Best regards Damon
