Re: [PATCH v2 3/6] dt-bindings: mfd: add max77759 binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2025-02-28 at 07:01 -0600, Rob Herring wrote:
> On Thu, Feb 27, 2025 at 7:14 AM André Draszik <andre.draszik@xxxxxxxxxx> wrote:
> > 
> > On Thu, 2025-02-27 at 07:04 -0600, Rob Herring wrote:
> > >
> > > 
> > > Why do you have GPIO properties here and in the child node? Either would
> > > be valid, but both probably not. Putting them here is actually
> > > preferred.
> > 
> > That's an oversight, I meant to put them into the child only, not here,
> > since the child is the one providing the gpio functionality.
> > 
> > What's the reason to have it preferred inside this parent node?
> 
> It really depends whether the GPIO block is a separate sub-block which
> is going to get reused or has its own resources or not. It's the same
> thing in system controllers which are often just a collection of
> leftover control bits.
> 
> We just don't want child nodes created just for the ease of
> instantiating drivers in Linux. While it's nice if drivers and nodes
> are 1 to 1, but that's specific to an OS.
> 
> You already need other child nodes here, so I don't care too much in this case.

Thanks Rob for taking the time and for the explanation! I'll keep
that in mind for the future.

Cheers,
Andre'







[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux