On 05/04/2015 08:30 PM, Jassi Brar wrote:
On Tue, May 5, 2015 at 6:27 AM, Eric Anholt <eric@xxxxxxxxxx> wrote:
Jassi Brar <jassisinghbrar@xxxxxxxxx> writes:
On Wed, Apr 29, 2015 at 10:39 PM, Eric Anholt <eric@xxxxxxxxxx> wrote:
+
+struct bcm2835_mbox {
+ struct device *dev;
+ void __iomem *regs;
+ spinlock_t lock;
+ struct mbox_controller controller;
+};
+
+static struct bcm2835_mbox *mbox;
+
+static irqreturn_t bcm2835_mbox_irq(int irq, void *dev_id)
+{
+ struct device *dev = mbox->dev;
+ struct mbox_chan *link = &mbox->controller.chans[0];
+
I learn from Stephen's other post that the controller could have
multiple channels. In which case this driver is poorly setup. Actually
if the driver was designed properly there isn't anything special to be
done.
Here you choose to waste 'dev_id' and hard-code dereferencing to channel-0
There's only the one channel according to the docs. I wish we wouldn't
get derailed by speculation on the list when the documentation is
available. :(
Can I have the pointer to the doc please, if its publicly available.
https://www.raspberrypi.org/wp-content/uploads/2012/02/BCM2835-ARM-Peripherals.pdf
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
