On Thu, 20 Feb 2025 at 19:58, Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> wrote: > > Hi, > > I got a report, that the Linux kernel crashes on Rock 5B when the panthor > driver is loaded late after booting. The crash starts with the following > shortened error print: > > rockchip-pm-domain fd8d8000.power-management:power-controller: failed to set domain 'gpu', val=0 > rockchip-pm-domain fd8d8000.power-management:power-controller: failed to get ack on domain 'gpu', val=0xa9fff > SError Interrupt on CPU4, code 0x00000000be000411 -- SError > > This series first does some cleanups in the Rockchip power domain > driver and changes the driver, so that it no longer tries to continue > when it fails to enable a domain. This gets rid of the SError interrupt > and long backtraces. But the kernel still hangs when it fails to enable > a power domain. I have not done further analysis to check if that can > be avoided. > > Last but not least this provides a fix for the GPU power domain failing > to get enabled - after some testing from my side it seems to require the > GPU voltage supply to be enabled. > > This introduces devm_of_regulator_get without the _optional suffix, since > that is more sensible for the Rockchip usecase. Longer explanation can be > seen in patch 6, which adds the handling to the Rockchip driver. My merge > suggestion would be that Mark provides an immutable branch to Ulf. > > The last patch, which updates the RK3588 board files should cover all RK3588 > boards that are currently in Heiko's for-next branch. Any board missing the > update will behave as before, so it is perfectly fine not to update all DT > files at once (in case I missed any). > > This is based on Heiko's for-next branch. Also it's probably worth mentioning, > that mesa CI is carrying this patchset for quite some time now. [...] I have pulled patch 1 from Mark's tree and applied patch 2 -> patch 7 for next. Note that, patch6 (the DT patch) is also available on the immutable dt branch. Thanks and kind regards Uffe
