On Thu, 2025-02-27 at 20:26 -0600, Rob Herring (Arm) wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On Fri, 28 Feb 2025 09:16:25 +0800, Cathy Xu wrote: > > Add the new binding document for pinctrl on MediaTek mt8196. > > > > Signed-off-by: Guodong Liu <guodong.liu@xxxxxxxxxxxx> > > Signed-off-by: Cathy Xu <ot_cathy.xu@xxxxxxxxxxxx> > > --- > > .../pinctrl/mediatek,mt8196-pinctrl.yaml | 241 > > ++++++++++++++++++ > > 1 file changed, 241 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/pinctrl/mediatek,mt8196- > > pinctrl.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: Sorry, this patch depond on another patch: https://patchwork.kernel.org/project/linux-mediatek/patch/20250228011702.16493-3-ot_cathy.xu@xxxxxxxxxxxx/ In this case, does the dt-binding still need go first? If so, I will include the dependency information in the commit message of the next version. Thank you~ > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/pinctrl/mediatek,mt8196- > pinctrl.example.dts:24:18: fatal error: > ../../../../arch/arm64/boot/dts/mediatek/mt8196-pinfunc.h: No such > file or directory > 24 | #include > "../../../../arch/arm64/boot/dts/mediatek/mt8196-pinfunc.h" > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ~~~~~~~~~~~~~~~ > compilation terminated. > make[2]: *** [scripts/Makefile.dtbs:131: > Documentation/devicetree/bindings/pinctrl/mediatek,mt8196- > pinctrl.example.dtb] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1511: > dt_binding_check] Error 2 > make: *** [Makefile:251: __sub-make] Error 2 > > doc reference errors (make refcheckdocs): > > See > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250228011702.16493-2-ot_cathy.xu@xxxxxxxxxxxx > > The base for the series is generally the latest rc1. A different > dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up > to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. > Note > that DT_SCHEMA_FILES can be set to your schema file to speed up > checking > your schema. However, it must be unset to test all examples with your > schema. >