> -----Original Message----- > From: Rob Herring (Arm) <robh@xxxxxxxxxx> > Sent: Thursday, February 27, 2025 12:24 PM > To: Wilson Ding <dingwei@xxxxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Sanghoon Lee <salee@xxxxxxxxxxx>; > conor+dt@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > gregory.clement@xxxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; Geethasowjanya > Akula <gakula@xxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; andrew@xxxxxxx; > krzk+dt@xxxxxxxxxx; sebastian.hesselbarth@xxxxxxxxx > Subject: [EXTERNAL] Re: [PATCH v3 1/3] dt-bindings: reset: Add Armada8K > reset controller > > On Thu, 27 Feb 2025 11: 25: 34 -0800, Wilson Ding wrote: > Add device-tree > binding documentation for the Armada8K reset driver and > create the new > head file for the reset line index definitions. > > Signed-off-by: Wilson Ding > <dingwei@ marvell. com> > > > On Thu, 27 Feb 2025 11:25:34 -0800, Wilson Ding wrote: > > Add device-tree binding documentation for the Armada8K reset driver and > > create the new head file for the reset line index definitions. > > > > Signed-off-by: Wilson Ding <dingwei@xxxxxxxxxxx> > > --- > > .../reset/marvell,armada8k-reset.yaml | 48 +++++++++++++++++++ > > .../reset/marvell,armada8k-reset.h | 27 +++++++++++ > > 2 files changed, 75 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/reset/marvell,armada8k-reset.yaml > > create mode 100644 include/dt-bindings/reset/marvell,armada8k-reset.h > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/reset/marvell,armada8k- > reset.example.dtb: system-controller@440000: compatible: ['syscon', 'simple- > mfd'] is too short > from schema $id: https://urldefense.proofpoint.com/v2/url?u=http- > 3A__devicetree.org_schemas_mfd_syscon-2Dcommon.yaml- > 23&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=sXDQZu4GyqNVDlFUXakS > GJl0Dh81ZIPlU26YS4KHGIA&m=xw0M-- > 2th9TCt05M0q_c8C0jvg1t4qbuXx9_d3WgCc0HOBpg5_f5E6TjXP_xdcrU&s=3 > Gdm4ABV10PnYEpAvJXrV9x-TsfBAHIp5KCn60ohngM&e= > > doc reference errors (make refcheckdocs): > > See https://urldefense.proofpoint.com/v2/url?u=https- > 3A__patchwork.ozlabs.org_project_devicetree- > 2Dbindings_patch_20250227192536.2426490-2D2-2Ddingwei- > 40marvell.com&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=sXDQZu4GyqN > VDlFUXakSGJl0Dh81ZIPlU26YS4KHGIA&m=xw0M-- > 2th9TCt05M0q_c8C0jvg1t4qbuXx9_d3WgCc0HOBpg5_f5E6TjXP_xdcrU&s= > WJznALBWhejS9hq88jCvZqevaNdN_5-meKfowRfl-bA&e= > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your > schema. I cannot reproduce the above error with the latest 'yamllint' and 'dt-schema'. $ pip3 install dtschema --upgrade Requirement already satisfied: dtschema in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (2025.2) Requirement already satisfied: ruamel.yaml>0.15.69 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from dtschema) (0.18.10) Requirement already satisfied: jsonschema<4.18,>=4.1.2 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from dtschema) (4.17.3) Requirement already satisfied: rfc3987 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from dtschema) (1.3.8) Requirement already satisfied: pylibfdt in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from dtschema) (1.7.2) Requirement already satisfied: attrs>=17.4.0 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (25.1.0) Requirement already satisfied: pyrsistent!=0.17.0,!=0.17.1,!=0.17.2,>=0.14.0 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from jsonschema<4.18,>=4.1.2->dtschema) (0.20.0) Requirement already satisfied: ruamel.yaml.clib>=0.2.7 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from ruamel.yaml>0.15.69->dtschema) (0.2.12) $ pip3 install yamllint Requirement already satisfied: yamllint in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (1.35.1) Requirement already satisfied: pathspec>=0.5.3 in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from yamllint) (0.12.1) Requirement already satisfied: pyyaml in /home/wilson/workspace/repos/external/venv/lib/python3.12/site-packages (from yamllint) (6.0.2) $ make dt_binding_check SCHEMA Documentation/devicetree/bindings/processed-schema.json CHKDT ./Documentation/devicetree/bindings LINT ./Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/reset/marvell,armada8k-reset.example.dts DTC [C] Documentation/devicetree/bindings/reset/marvell,armada8k-reset.example.dtb - Wilson
