Hi Dmitry, On 2/27/2025 10:29 AM, Dmitry Baryshkov wrote: > On Mon, Jan 13, 2025 at 01:52:13PM -0800, Melody Olvera wrote: >> From: Wesley Cheng <quic_wcheng@xxxxxxxxxxx> >> >> Enable USB support on SM8750 MTP and QRD variants. SM8750 has a QMP combo >> PHY for the SSUSB path, and a M31 eUSB2 PHY for the HSUSB path. >> >> Signed-off-by: Wesley Cheng <quic_wcheng@xxxxxxxxxxx> >> Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx> >> --- >> arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 24 ++++++ >> arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 24 ++++++ >> arch/arm64/boot/dts/qcom/sm8750.dtsi | 134 ++++++++++++++++++++++++++++++++ >> 3 files changed, 182 insertions(+) >> > >> + >> + usb_dp_qmpphy: phy@88e8000 { >> + compatible = "qcom,sm8750-qmp-usb3-dp-phy"; >> + reg = <0x0 0x088e8000 0x0 0x3000>; > > If I understand anything correctly, this should be 0x4000, not 0x3000. > You have missed the DP part of it. ACK, will fix that. Thanks. Thanks Wesley Cheng