On Thu, 13 Feb 2025 19:19:48 -0600 "Rob Herring (Arm)" <robh@xxxxxxxxxx> wrote: Hi Rob, > On Fri, 14 Feb 2025 00:37:32 +0000, Andre Przywara wrote: > > The A523 contains a pin controller similar to previous SoCs, although > > using 10 GPIO banks (PortB-PortK), all of them being IRQ capable. > > With this SoC we introduce a new style of binding, where the pinmux values > > for each pin group are stored in the new "allwinner,pinmux" property in > > the DT node, instead of requiring every driver to store a mapping between > > the function names and the required pinmux. > > > > Add a new binding file, since all the different variants of the old > > binding are making the file a bit unwieldy to handle already, and the new > > property would make the situation worse. > > > > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> > > --- > > .../allwinner,sun55i-a523-pinctrl.yaml | 177 ++++++++++++++++++ > > 1 file changed, 177 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.example.dts:24:18: fatal error: dt-bindings/clock/sun55i-a523-r-ccu.h: No such file or directory > 24 | #include <dt-bindings/clock/sun55i-a523-r-ccu.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Ah yeah, of course, that's in another series. What's the best approach here? I could cheekily import an existing header file, the symbol names in there are often the same (ccu-sun20i-d1-r.h defines the same symbol, even with the same number). Or I just replace it below with the number "1"? Or let git format-patch append the patch-id of the clock binding header patch? Cheers, Andre > compilation terminated. > make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.example.dtb] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1511: dt_binding_check] Error 2 > make: *** [Makefile:251: __sub-make] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250214003734.14944-7-andre.przywara@xxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
