Hi Geert,
Thanks for your review.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Thursday, February 27, 2025 10:11 AM
> Subject: Re: [PATCH 3/7] dt-bindings: thermal: r9a09g047-tsu: Document the
> TSU unit
>
> Hi John,
>
> On Wed, 26 Feb 2025 at 16:40, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> wrote:
> > > > + interrupts:
> > > > + description: |
> > > > + Interrupt specifiers for the TSU:
> > > > + - S12TSUADI1: Conversion complete interrupt signal (pulse)
> > > > + - S12TSUADCMPI1: Comparison result interrupt signal (level)
> > > > +
> > > > + interrupt-names:
> > > > + items:
> > > > + - const: S12TSUADI1
> > > > + - const: S12TSUADCMPI1
> > >
>
> These are the names from the point of view of the interrupt controller
> (Section 4.6 Interrupt Controller Table 4.6-24 List of Input Events).
> The silly "1" suffix does seem have a meaning here, as S12TSUADI0 seems to
> be a DMAC request signal...
>
> For the TSU bindings, we want the names from the point of view of the TSU.
> Section 7.11 Temperature Sensor Unit (TSU) Table 7.11-3 List of Internal
> I/O Pins lists:
> - S12TSUADI: Conversion complete interrupt signal (pulse)
> - S12TSUADCMPI: Comparison result interrupt signal (level)
>
> So I'd go for "adi" and "adcmpi".
All right. I'll go for it in v2.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
Regards,
John
