On 26/02/2025 18:10, David Lechner wrote:
On 2/26/25 12:28 AM, Matti Vaittinen wrote:
Hi David,
Thanks for taking a look at this :)
On 26/02/2025 02:26, David Lechner wrote:
On 2/24/25 12:33 PM, Matti Vaittinen wrote:
...
Similarly, on several drivers we added recently that make use of adc.yaml
(adi,ad7380, adi,ad4695) we wrote the bindings with the intention that
if a channel was wired in the default configuration, then you would just
omit the channel node for that input pin. Therefore, this helper couldn't
be used by these drivers since we always have a fixed number of channels
used in the driver regardless of if there are explicit channel nodes in
the devicetree or not.
I think this works with the ICs where channels, indeed, always are there. But this is not the case with _all_ ICs. And in order to keep the consistency I'd actually required that if channels are listed in the DT, then _all_ the channels must be listed. Else it becomes less straightforward for people to understand how many channels there are based on the device tree. I believe this was also proposed by Jonathan during the v1 review:
Hmm. That'd mean the ADC channels _must_ be defined in DT in order to be
usable(?) Well, if this is the usual way, then it should be well known
by users. Thanks.
Yes. We basically have two types of binding wrt to channels.
1) Always there - no explicit binding, but also no way to describe
anything specific about the channels.
2) Subnode per channel with stuff from adc.yaml and anything device
specific. Only channels that that have a node are enabled.
Hmm... does that mean we implemented it wrong on ad7380 and ad4695?
I believe this is a question to Jonathan. With my ADC-driver experience
I am not the person to answer this :)
_If_ I commented something to this, I would say that: "I believe, this
question is a good example of why providing helpers is so powerful. In
my experience, when we provide helpers, then there will be a 'de facto'
way of doing things, which improves consistency". But as I feel I'm on
the verge of stepping on someones toes (and I am really the novice on
this area), I won't say that comment out loud.
There are a few drivers that for historical reasons support both
options with 'no channels' meaning 'all channels'.
https://lore.kernel.org/all/20250201162631.2eab9a9a@jic23-huawei/
In my experience, the only time we don't populate all available channels
on an ADC, even if not used, is in cases like differential chips where
any two inputs can be mixed and matched to form a channel. Some of these,
like adi,ad7173-8 would have 100s or 1000s of channels if we tried to
include all possible channels. In those cases, we make an exception and
use a dynamic number of channels based on the devicetree. But for chips
that have less than 20 total possible channels or so we've always
provided all possible channels to userspace. It makes writing userspace
software for a specific chip easier if we can always assume that chip
has the same number of channels.
In any exception to this rule of describing all channels in DT should just avoid using these helpers and do things as they're done now. No one is forced to use them. But I am not really sure why would you not describe all the channels in the device-tree for ICs with less than 20 channels? I'd assume that if the channels are unconditionally usable in the hardware, then they should be in DT as well(?)
I devicetree, I think the tendency is to be less verbose and only add
properties/nodes when there is something that is not the usual case.
Default values are chosen to be the most usual case so we don't have
to write so much in the .dts.
On the other hand, I've received comments from the DTS people to expose
all HW blocks in the bindings. AFAIR, for example, marking
power-supplies as 'optional' in bindings is frowned upon, because they
are in the HW whether the SW needs to control them or not. Hence I think
marking either all or no channels in dt should be the way to go - but my
thinking is not done based on the years of experience on ADCs!
Add couple of helper functions which can be used to retrieve the channel
information from the device node.
Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
Yours,
-- Matti
