On Mon, 2025-02-17 at 16:48 +0100, AngeloGioacchino Del Regno wrote: > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over > syscon_regmap_lookup_by_phandle() combined with getting the syscon > argument. Except simpler code this annotates within one line that given > phandle has arguments, so grepping for code would be easier. > > There is also no real benefit in printing errors on missing syscon > argument, because this is done just too late: runtime check on > static/build-time data. Dtschema and Devicetree bindings offer the > static/build-time check for this already. I would apply bug-fix, cleanup, and refinement patches first and then apply v2 related patches. So bug-fix, cleanup, and refinement patches could be backported to old version branch without any v2 related patches. When I apply this patch, conflicts happen. Please rebase this series onto mediatek-drm-next, and apply this patch before v2 related patches. Regards, CK > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > [Angelo: Rebased over HDMIv2/DDCv2 series cleanups] > Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > ---