On 26/02/2025 21:13, Sebastian LaVine wrote: >> ... >> >>> + >>> +static int imx728_set_stream(struct v4l2_subdev *sd, int enable) >>> +{ >>> + struct imx728 *imx728 = to_imx728(sd); >>> + int ret; >>> + >>> + mutex_lock(&imx728->lock); >> >> Just use guard. That's actually perfect candidate. >> > > Okay -- I'll include this change in v4. I'm not so familiar with using > this interface, so please let me know if this is incorrect: > Yes, looks fine. Best regards, Krzysztof