On Wed, 2025-02-26 at 15:42 +0000, André Draszik wrote: > On Wed, 2025-02-26 at 09:29 -0600, Rob Herring (Arm) wrote: > > > > On Wed, 26 Feb 2025 14:08:20 +0000, André Draszik wrote: > > > Add support for specifying different register/mask/value combinations > > > for different types of reset. > > > > > > In particular, update the binding to allow platforms to specify the > > > following reset modes: soft, warm, cold, hard. > > > > > > Linux can perform different types of reset using its reboot= kernel > > > command line argument, and some platforms also wish to reset > > > differently based on whether or not e.g. contents of RAM should be > > > retained across the reboot. > > > > > > The new properties match the existing properties, just prefixed with > > > one of the reset modes mentioned above. > > > > > > Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx> > > > --- > > > .../bindings/power/reset/syscon-reboot.yaml | 74 ++++++++++++++++++++++ > > > 1 file changed, 74 insertions(+) > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > oops, sorry - the script we usually run didn't cover this binding, BTW, we did that, because it's easy to miss warnings due to the amount of bindings and text scrolling past. Ideally make would exit with != 0 in case of binding errors. I can see in commit 3e95dfb315de ("dt-bindings: Don't error out on yamllint and dt-doc-validate errors"), warnings are never treated as errors. Is that still relevant, can that commit be revert? Don't we want the build to fail loudly on binding errors, so that people don't even submit erroneous bindings in the first place? Cheers, Andre'