Re: [PATCH v1 6/9] dt-bindings: memory: Document Tegra114 External Memory Controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ср, 26 лют. 2025 р. о 17:15 Rob Herring <robh@xxxxxxxxxx> пише:
>
> On Tue, Feb 25, 2025 at 04:34:58PM +0200, Svyatoslav Ryhel wrote:
> > Document External Memory Controller found in the Tegra 4 SoC.
>
> This all looks very close to tegra124. Could have missed something, but
> I see 1 property difference and 'nvidia,emc-configuration' is slightly
> different. I'd just add tegra114 to the existing schema. For
> 'nvidia,emc-configuration', I would just list the range for the length.
> It's just a list of magic register values, so we can't really do any
> validation of it. And I don't care what register is which entry. If you
> really want to document that, then keep the existing list and put 0
> value entries for any registers that don't exist on tegra114 and put new
> registers on the end of the list.
>

You are totally correct, my first intention was to reuse tegra124
schema, but I did not knew how to handle the timing list correctly.
Tegra114 version does not have one of the entries in that list. I have
tried to use condition to define additional entry but yaml check
continued to complain. Maybe you can show an example where similar
situation is resolved? Thank you.

> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> > ---
> >  .../nvidia,tegra114-emc.yaml                  | 431 ++++++++++++++++++
> >  1 file changed, 431 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-emc.yaml





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux