On Tue, Feb 25, 2025, at 23:25, Roman Kisel wrote: > On 2/24/2025 11:24 PM, Arnd Bergmann wrote: >> On Tue, Feb 25, 2025, at 00:22, Roman Kisel wrote: >>> Hi Arnd, >> >> If you want to declare a uuid here, I think you should remove the >> ARM_SMCCC_VENDOR_HYP_UID_HYPERV_REG_{0,1,2,3} macros and just >> have UUID in normal UUID_INIT() notation as we do for >> other UUIDs. > > I'd gladly stick to that provided I have your support of touching > KVM's code! As the SMCCC document states, there shall be an UUID, > and in the kernel, there would be > > #define ARM_SMCCC_VENDOR_KVM_UID UUID_INIT(.......) > #define ARM_SMCCC_VENDOR_HYP_UID UUID_INIT(.......) > > Hence, the ARM_SMCCC_VENDOR_HYP_UID_*_REG_{0,1,2,3} can be removed as > you're suggesting. Yes, I think that's the best way forward, as it improves the existing KVM code and all future functions like it. Arnd