On Wed, Feb 26, 2025 at 01:18:16PM +0000, Mark Brown wrote: > On Fri, Feb 14, 2025 at 05:18:17PM +0200, Andy Shevchenko wrote: > > On Fri, Feb 14, 2025 at 12:49:56PM +0100, Mathieu Dubois-Briand wrote: > > > > + int ret, i; > > > unsigned int i; > > ? > > If it's just an iterator it's idiomatic to use signed ints. IIRC if it > makes a difference to the code generation it's likely to be positive. It depends on the subsystem, V4L2, for example, is strict to unsigned types when they are unsigned. It also helps to catch some strange conditionals at some point when one checks for negative value in the (incrementing) counter. But I'm not insisting as you may notice by question mark used. -- With Best Regards, Andy Shevchenko
