On 2025/2/25 22:20, Andy Shevchenko wrote: > I would add here that the of.h includes fwnode.h already, so it doesn't > add any new compile time dependency. > thank you Andy for comments. include/linux/of.h: struct device_node { ... struct fwnode_handle fwnode; // this type is defined by fwnode.h ... } include/linux/fwnode.h: struct fwnode_handle {...} So of.h must include fwnode.h Perhaps, of.h needs to include fwnode.h *explicitly* even if this is another topic. > Both patches LGTM, > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>