On 2/26/25 13:16, Hans Verkuil wrote: >> +/* vb2 queue */ >> +static const struct vb2_ops hdmirx_vb2_ops = { >> + .queue_setup = hdmirx_queue_setup, >> + .buf_queue = hdmirx_buf_queue, >> + .wait_prepare = vb2_ops_wait_prepare, >> + .wait_finish = vb2_ops_wait_finish, > These two ops are no longer needed. New drivers must not use them. I'm > working on removing these ops, but it's not quite there yet. > > I will remove these two lines manually for this v11, but if a v12 is needed, > then make sure you drop these two lines. Ack. Thanks for the review! -- Best regards, Dmitry