On 2025-02-25 00:48, Krzysztof Kozlowski wrote: > On 24/02/2025 18:37, Kaustabh Chakraborty wrote: >> On 2025-02-23 16:10, Krzysztof Kozlowski wrote: >>> Missing bindings. >> >> Bindings have been applied in v1. > > Heh, I see email from Lee now but mainline does not have them, next from > 19th Feb neither. I see it in lee/mfd/for-mfd-next. [1] > > BTW, what happened with all the review tags? Nothing in cover letter nor > changelog explains dropping reviews. Haven't explicitly mentioned dropping the tags, but I've changed the macros a bit, among other things (which is mentioned in cover). I assume that's the standard procedure. > >> >>> BTW, don't combine independent patches from different subsystems into >>> one patchset. It's not helping anyone especially without explaining >>> dependencies/merging in the cover letter or here in changelog. >> >> Alright I'm a bit lost here. The binding patch (the one you enquired >> for above) referenced the regulator bindings, whereas the regulator >> driver is including the S2MU005 PMIC header which defines the >> register addresses, etc. > > You have entire cover letter to explain dependencies and merging... If > you target specific subsystem - write. Okay, I do have that in there, but the wording is indeed quite vague. Will try to improve it in v3. Though the PMIC's dt-binding patch has been merged... so not really sure what to assert now. [1] https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=for-mfd-next&id=d237e8037d524bc5683d27268086620c5df605ea
