On 17.02.2025 12:32 PM, David Wronek wrote:
> Add the initial devicetree for the Lenovo Xiaoxin Pad Pro 2021 Android
> tablet with the following features:
>
> - Wi-Fi and Bluetooth (QCA6390)
> - Detachable keyboard & touchpad accessory (Connected to an MCU)
> - Fuel gauge (TI BQ27541)
> - USB
> - UFS
> - Buttons
> - Remoteprocs
> - simple-framebuffer
>
> Signed-off-by: David Wronek <david@xxxxxxxxxxxxxx>
> ---
[...]
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&volume_up_n>;
property-n
property-names
please (file-wide)
[...]
> +&i2c1 {
> + clock-frequency = <1000000>;
> + status = "okay";
Please add a newline before status (file-wide)
> +
> + touchpad@60 {
> + compatible = "hid-over-i2c";
> + reg = <0x60>;
> +
> + vdd-supply = <&vreg_l16a_3p3>;
> + vddl-supply = <&vreg_l8c_1p8>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <14 IRQ_TYPE_LEVEL_LOW>;
interrupts-extended
also please align the property order with x1e80100-crd.dtsi
[...]
> +&i2c4 {
> + clock-frequency = <400000>;
> + status = "okay";
> +
> + /* onsemi NB7VPQ904M USB redriver @ 19 */
> + /* CS35L41 audio amp @ 40 */
> + /* CS35L41 audio amp @ 41 */
> + /* CS35L41 audio amp @ 42 */
> + /* CS35L41 audio amp @ 43 */
All of them have a driver nowadays, should be trivial to hook up :)
[...]
> +&i2c15 {
> + clock-frequency = <400000>;
> + status = "okay";
> +
> + /* SMB1390 charger @ 10 */
> + /* ES7210 audio ADC @ 40 */
> + /* FSA4480 USB audio switch @ 43 */
FSA4480 also has a driver
Konrad
