On Mon, Feb 24, 2025 at 09:17:03PM +0200, Mihalcea Laurentiu wrote: > > On 12.02.2025 01:23, Frank Li wrote: > > On Tue, Feb 11, 2025 at 05:58:08PM -0500, Laurentiu Mihalcea wrote: > >> From: Laurentiu Mihalcea <laurentiu.mihalcea@xxxxxxx> > >> > >> Add imx95 DTS for SOF usage. > >> > >> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@xxxxxxx> > >> --- > >> arch/arm64/boot/dts/freescale/Makefile | 1 + > >> .../dts/freescale/imx95-19x19-evk-sof.dts | 85 +++++++++++++++++++ > >> 2 files changed, 86 insertions(+) > >> create mode 100644 arch/arm64/boot/dts/freescale/imx95-19x19-evk-sof.dts > >> > >> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > >> index 839432153cc7..27f64e333e4b 100644 > >> --- a/arch/arm64/boot/dts/freescale/Makefile > >> +++ b/arch/arm64/boot/dts/freescale/Makefile > >> @@ -282,6 +282,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxca.dtb > >> dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla.dtb > >> dtb-$(CONFIG_ARCH_MXC) += imx93-var-som-symphony.dtb > >> dtb-$(CONFIG_ARCH_MXC) += imx95-19x19-evk.dtb > >> +dtb-$(CONFIG_ARCH_MXC) += imx95-19x19-evk-sof.dtb > > look like should use dt overlay ? > > > can you pls explain why you'd see this as an overlay? It is addtional option, which base on imx95-19x19-evk.dtb. Default wm8962 is used for built-in dai, this provide option to move it dsp. Ideally this option should work for all boards, which use wm8962. We try to move MxN problem to M + N. otherwise, there are huge numbers of dtb files. Frank > > (snip) > > >> + > >> + sof-sound-wm8962 { > >> + compatible = "audio-graph-card2"; > >> + links = <&cpu>; > >> + label = "wm8962-audio"; > >> + hp-det-gpios = <&gpio2 11 GPIO_ACTIVE_HIGH>; > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&pinctrl_hp>; > >> + widgets = > >> + "Headphone", "Headphones", > >> + "Microphone", "Headset Mic"; > > Generally, align to = > > widgets = "Headphone", "Headphones", > > "Microphone", "Headset Mic"; > > > sure > > > >> + routing = > >> + "Headphones", "HPOUTL", > >> + "Headphones", "HPOUTR", > >> + "Headset Mic", "MICBIAS", > >> + "IN3R", "Headset Mic", > >> + "IN1R", "Headset Mic"; > >> + }; > >> + > >> + sound-wm8962 { > >> + status = "disabled"; > >> + }; > >> + > >> +}; > >> + > >> +&edma2 { > >> + dma-channel-mask = <0xc0000000>, <0x0>; > >> +}; > > Not sure why need mask edma2's some channel, can you add comments for it > > > > Frank > > > sure, can add comment in commit msg >