Re: [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, May 04, 2015 at 06:51:32AM -0700, Kevin Cernekee wrote:
> On Mon, May 4, 2015 at 4:45 AM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Sun, May 03, 2015 at 05:00:18PM -0700, Kevin Cernekee wrote:
> >> +     if (dev->of_node) {
> >> +             const struct of_device_id *of_id;
> >> +
> >> +             of_id = of_match_device(tas571x_of_match, dev);
> >> +             if (of_id)
> >> +                     priv->chip = of_id->data;
> >> +     }

> > Doesn't of_match_device() do the right thing with devices not registered
> > from DT?

> Not sure.  What kinds of situations are you concerned about?

I'm wondering why we need to bother checking for dev->of_node before
calling it.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux