On Mon, Feb 24, 2025 at 04:39:08PM +0800, Stanley Chu wrote: > From: Stanley Chu <yschu@xxxxxxxxxxx> > > When MCONFIG.SKEW=0 and MCONFIG.ODHPP=0, the ENTDAA transaction gets > corrupted and results in a no repeated-start condition at the end of > address assignment. If there are errata doc, provide a link will be appeciated. > > Workaround: Set MCONFIG.SKEW to 1 before initiating the DAA process. > After the DAA process is completed, return MCONFIG.SKEW to its previous > value. > > Signed-off-by: Stanley Chu <yschu@xxxxxxxxxxx> Reviewed-by: Frank Li <Frank.Li@xxxxxxx> > --- > drivers/i3c/master/svc-i3c-master.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c > index 4eb4b8888725..403d625e999e 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c > @@ -1162,7 +1162,16 @@ static int svc_i3c_master_do_daa(struct i3c_master_controller *m) > } > > spin_lock_irqsave(&master->xferqueue.lock, flags); > + > + if (svc_has_quirk(master, SVC_I3C_QUIRK_DAA_CORRUPT)) > + writel(master->mctrl_config | SVC_I3C_MCONFIG_SKEW(1), > + master->regs + SVC_I3C_MCONFIG); > + > ret = svc_i3c_master_do_daa_locked(master, addrs, &dev_nb); > + > + if (svc_has_quirk(master, SVC_I3C_QUIRK_DAA_CORRUPT)) > + writel(master->mctrl_config, master->regs + SVC_I3C_MCONFIG); > + > spin_unlock_irqrestore(&master->xferqueue.lock, flags); > > svc_i3c_master_clear_merrwarn(master); > -- > 2.34.1 >
