On Mon, Feb 24, 2025 at 01:01:14PM +0530, Thippeswamy Havalige wrote: > This series of patch add support for AMD MDB IP as Root Port. > > The AMD MDB IP support's 32 bit and 64bit BAR's at Gen5 speed. Which PCIe controller does not support 64-bit BARs? Seems like quite a random sentence IMO. > As Root Port it supports MSI and legacy interrupts. You are not submitting Endpoint mode support for your controller, so it seems a bit weird to talk about "As Root Port ...". Your patch only includes Root Complex mode, and makes no reference to Endpoint mode anywhere, so perhaps just state that the controller supports MSI and INTx interrupts. Kind regards, Niklas
